From 1ff0237dde85e7239d7440c4827c69da5b36815a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hera=20=28=ED=97=A4=EB=9D=BC=29?= Date: Sat, 19 Sep 2026 10:40:56 +0000 Subject: [PATCH] docs: polish English wording --- README.md | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index ed124dc..a6d6b01 100644 --- a/README.md +++ b/README.md @@ -4,9 +4,9 @@ Minimal custom app that adds an icon-only **댓글** action directly to each eli ## Why these APIs -The installed Nextcloud 34.0.4 bundle uses `@nextcloud/files` 4.0.0. The app registers `oc:comments-count` before the Files listing loads, then uses the count to choose the row icon. It registers a supported custom Files sidebar tab and mounts Nextcloud Comments' native `OCA.Comments.View` in that tab, retaining native creation, history, edit, delete, mention, and permission behavior while avoiding the mixed Activity feed. +The installed Nextcloud 34.0.4 bundle uses `@nextcloud/files` 4.0.0. The app registers `oc:comments-count` before the Files listing loads, then uses that count to choose the row icon. It also registers a custom Files sidebar tab and mounts Nextcloud's native `OCA.Comments.View` there. This keeps the existing interface and permission rules for writing, reading, mentioning users, editing, and deleting comments while keeping unrelated Activity entries out of the way. -Nextcloud's built-in `comments-unread` row action is reused when unread comments exist so users still see only one comment icon. Its click target and icon are aligned with the dedicated comments-only tab; the custom action covers rows without unread comments. +When a file has unread comments, the app reuses Nextcloud's built-in `comments-unread` action instead of adding a second icon. Both actions use the same icon style and open the dedicated comments-only tab. ## Screenshot @@ -29,9 +29,9 @@ npm run build The production entry is generated as `js/korean_comments_action-main.mjs`. The listener therefore calls `Util::addInitScript(Application::APP_ID, Application::APP_ID . '-main')`; passing only `'main'` would incorrectly resolve the nonexistent `js/main.mjs`. -## Deployment commands (not run during this investigation) +## Deployment -Copy the app directory to `/data/nextcloud/app/custom_apps/korean_comments_action`, retaining `appinfo/`, `lib/`, and generated `js/` (source/build metadata may also be retained), then run OCC in the Nextcloud PHP container as the web user: +Copy the app directory to `/data/nextcloud/app/custom_apps/korean_comments_action`. Keep `appinfo/`, `lib/`, and the generated `js/` directory, then run OCC in the Nextcloud PHP container as the web user: ```bash php occ app:enable korean_comments_action @@ -47,13 +47,13 @@ php occ app:disable korean_comments_action ## Manual acceptance test -1. Open **Files → Personal files**. Confirm each eligible row shows only an icon without a `댓글` text label or a required `…` menu click. +1. Open **Files → Personal files**. Confirm that each eligible row shows an icon without a `댓글` text label and without opening the `…` menu. 2. Confirm a file with no comments uses an empty square and a file with one or more comments uses a square containing three dots. -3. Click either icon. Confirm the dedicated **댓글** tab opens for that exact file and contains the comment input plus comment history, with no Activity entries. +3. Click either icon. Confirm that the dedicated **댓글** tab opens for that file and shows the comment box and existing comments, with no Activity entries. 4. Create a comment, then edit and delete one of your own comments. Confirm the native controls and list updates work. 5. Click the same file's icon again while the sidebar is already open. Confirm the dedicated **댓글** tab remains active and never falls back to **활동**. 6. With the sidebar still open, use the icon on another file. Confirm the sidebar header, input, and comments belong to the second file. -7. Select multiple rows. Confirm the action is not offered. Confirm it is also absent for nodes outside the supported `/files/` tree, nodes without a file ID, nodes with `Permission.NONE`, or when the Comments app is unavailable. +7. Select multiple rows and confirm that the action is hidden. It should also be hidden for items outside the supported `/files/` tree, items without a file ID, items with `Permission.NONE`, and whenever the Comments app is unavailable. ## Primary references @@ -65,12 +65,12 @@ php occ app:disable korean_comments_action ## Upstream discussion -The verified findings and prototype design were shared, with the user's explicit permission and AI-authorship disclosure, in Nextcloud's existing issue: +The findings and prototype design were shared in an existing Nextcloud issue. The GitHub comment states that an AI agent wrote it at the user's request and posted it with the user's explicit permission: - https://github.com/nextcloud/server/issues/31422#issuecomment-5740952201 ## License and public access -This repository is publicly readable and distributed under the **GNU Affero General Public License v3.0 or later (`AGPL-3.0-or-later`)**, matching the license used by Nextcloud Server and the Nextcloud Files frontend library. Anyone may download, use, inspect, modify, and redistribute the source under the terms of that license. Anonymous visitors have read/clone access only; repository write access remains restricted to authorized maintainers. +This is a public repository distributed under the **GNU Affero General Public License v3.0 or later (`AGPL-3.0-or-later`)**, the same license used by Nextcloud Server and the Nextcloud Files frontend library. Anyone may download, inspect, use, modify, and redistribute the source under those terms. Visitors can view or clone the repository without signing in, but only authorized maintainers can push changes. See [LICENSE](LICENSE) for the complete terms.