[verified] show comments as inline file action

This commit is contained in:
2026-09-19 08:47:34 +00:00
parent 56df1251b9
commit a2bfb69ea8
9 changed files with 13 additions and 13 deletions
+2 -2
View File
@@ -1,6 +1,6 @@
# Korean comments action for Nextcloud 34 # Korean comments action for Nextcloud 34
Minimal custom app that adds **댓글** to each eligible Files row action menu and opens that node's comments UI. On Nextcloud 34 with Activity enabled, comments are integrated into sidebar tab `activity`; if Activity is disabled, the app falls back to tab `comments`. Minimal custom app that adds a **댓글** icon directly to each eligible Files row and opens that node's comments UI without using the `…` menu. On Nextcloud 34 with Activity enabled, comments are integrated into sidebar tab `activity`; if Activity is disabled, the app falls back to tab `comments`.
## Why these APIs ## Why these APIs
@@ -39,7 +39,7 @@ php occ app:disable korean_comments_action
## Manual acceptance test ## Manual acceptance test
1. Open **Files → Personal files**, then open a file row's `…` menu. Confirm one **댓글** item appears and is not an inline icon. 1. Open **Files → Personal files**. Confirm one **댓글** icon appears directly on every eligible file row without opening the `…` menu.
2. Click **댓글**. Confirm the details sidebar opens for that exact filename, the **Activity** tab is active, existing comments load, and the comment composer is visible. 2. Click **댓글**. Confirm the details sidebar opens for that exact filename, the **Activity** tab is active, existing comments load, and the comment composer is visible.
3. On the same file, switch to another sidebar tab and click **댓글** again. Confirm it switches back to Activity without closing the sidebar. 3. On the same file, switch to another sidebar tab and click **댓글** again. Confirm it switches back to Activity without closing the sidebar.
4. With the sidebar still open, use **댓글** on another file. Confirm the sidebar header and comments belong to the second file. 4. With the sidebar still open, use **댓글** on another file. Confirm the sidebar header and comments belong to the second file.
+2 -2
View File
@@ -3,9 +3,9 @@
xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd"> xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd">
<id>korean_comments_action</id> <id>korean_comments_action</id>
<name>Korean comments action</name> <name>Korean comments action</name>
<summary>Adds a 댓글 action to the Files row menu</summary> <summary>Adds a 댓글 icon directly to eligible Files rows</summary>
<description>Adds a Korean-labeled file action that opens the Activity/comments sidebar.</description> <description>Adds a Korean-labeled file action that opens the Activity/comments sidebar.</description>
<version>1.0.1</version> <version>1.0.2</version>
<licence>agpl</licence> <licence>agpl</licence>
<author>Hera (헤라)</author> <author>Hera (헤라)</author>
<namespace>KoreanCommentsAction</namespace> <namespace>KoreanCommentsAction</namespace>
File diff suppressed because one or more lines are too long
+1 -1
View File
@@ -138,7 +138,7 @@ This file is generated from multiple sources. Included packages:
- version: 1.1.15 - version: 1.1.15
- license: MIT - license: MIT
- korean-comments-action - korean-comments-action
- version: 1.0.1 - version: 1.0.2
- license: undefined - license: undefined
- math-intrinsics - math-intrinsics
- version: 1.1.0 - version: 1.1.0
File diff suppressed because one or more lines are too long
+2 -2
View File
@@ -1,12 +1,12 @@
{ {
"name": "korean-comments-action", "name": "korean-comments-action",
"version": "1.0.1", "version": "1.0.2",
"lockfileVersion": 3, "lockfileVersion": 3,
"requires": true, "requires": true,
"packages": { "packages": {
"": { "": {
"name": "korean-comments-action", "name": "korean-comments-action",
"version": "1.0.1", "version": "1.0.2",
"dependencies": { "dependencies": {
"@nextcloud/files": "4.0.0", "@nextcloud/files": "4.0.0",
"@nextcloud/initial-state": "3.0.0" "@nextcloud/initial-state": "3.0.0"
+1 -1
View File
@@ -1,6 +1,6 @@
{ {
"name": "korean-comments-action", "name": "korean-comments-action",
"version": "1.0.1", "version": "1.0.2",
"private": true, "private": true,
"type": "module", "type": "module",
"scripts": { "scripts": {
+1 -1
View File
@@ -62,7 +62,7 @@ export const action: IFileAction = {
return false return false
} }
}, },
inline: () => false, inline: () => true,
order: -45, order: -45,
} }
+2 -2
View File
@@ -51,10 +51,10 @@ beforeEach(() => {
}) })
describe('Korean comments file action', () => { describe('Korean comments file action', () => {
it('registers a non-inline 댓글 action', () => { it('registers an inline 댓글 action for file rows', () => {
expect(mocks.registerFileAction).toHaveBeenCalledWith(action) expect(mocks.registerFileAction).toHaveBeenCalledWith(action)
expect(action.displayName(context as never)).toBe('댓글') expect(action.displayName(context as never)).toBe('댓글')
expect(action.inline?.(context as never)).toBe(false) expect(action.inline?.(context as never)).toBe(true)
}) })
it('opens the integrated Activity tab', async () => { it('opens the integrated Activity tab', async () => {